feat: add hidden dance easter egg#260
Conversation
🦋 Changeset detectedLatest commit: d2a8d8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c92020e143
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| installRainbowDance(() => { | ||
| ui.requestRender(); | ||
| }); |
There was a problem hiding this comment.
When a user runs /dance and exits before DANCE_FLOW_MS elapses, the controller installed here remains in module state because KimiTUI.stop() stops the UI/harness but never disposes this controller. Its interval/timeout can keep the event loop alive and continue calling ui.requestRender() on a stopped UI in embeddings or tests that do not immediately process.exit; tie this installation to a disposer that is invoked during shutdown.
Useful? React with 👍 / 👎.
…er-egg # Conflicts: # apps/kimi-code/src/tui/commands/dispatch.ts
1 participant
Related Issue
No linked issue; this is a small hidden TUI easter egg requested by maintainers.
Problem
The TUI did not have a hidden visual easter egg for playful discovery.
What changed
/dancefallback command that runs after builtin command and skill resolution.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.